Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow absolute paths to setup folders #204

Open
bburns opened this issue Dec 16, 2022 · 3 comments
Open

Allow absolute paths to setup folders #204

bburns opened this issue Dec 16, 2022 · 3 comments
Assignees
Labels
application:cli Anything related to a specific application enhancement New feature or request infrastructure Anything related to the surrounding tools and infrastructure

Comments

@bburns
Copy link
Contributor

bburns commented Dec 16, 2022

ob: why l99 use requires the config to be under setups/ folder? When I use absolute path to the config folder, it should not prepend setups/ which results in setups//some/absolute/path.

bb: the idea was to just keep all configs in the setups folder - but will add 'allow absolute paths' to the tasklist

@bburns bburns self-assigned this Dec 16, 2022
@MRIIOT
Copy link
Contributor

MRIIOT commented Dec 17, 2022

Where do the changes need to happen?

@bburns
Copy link
Contributor Author

bburns commented Dec 17, 2022

anywhere the .l99_setup file is referenced - currently it just stores the setup name, eg 'oxbox', not a path

eg

https://github.com/Ladder99/ladder99/blob/main/shell/commands/use#L30-L31

https://github.com/Ladder99/ladder99/blob/main/shell/commands/start#L42-L44

@tukusejssirs
Copy link
Contributor

@bburns, how about we check if a particular env var is set? If it is not set, we use $PWD.

Something like this:

L99_HOME="${L99_HOME:-$PWD}"

@tukusejssirs tukusejssirs added enhancement New feature or request infrastructure Anything related to the surrounding tools and infrastructure labels Dec 22, 2022
@tukusejssirs tukusejssirs changed the title setup - allow absolute paths to setup folders Allow absolute paths to setup folders Dec 22, 2022
@bburns bburns added the application:cli Anything related to a specific application label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application:cli Anything related to a specific application enhancement New feature or request infrastructure Anything related to the surrounding tools and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants