Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W08H01: Missing Test: solveMazeFrom impossible path from position to exit #34

Closed
LadnerJonas opened this issue Dec 15, 2021 · 7 comments · Fixed by #33 or #36
Closed

W08H01: Missing Test: solveMazeFrom impossible path from position to exit #34

LadnerJonas opened this issue Dec 15, 2021 · 7 comments · Fixed by #33 or #36
Labels
help wanted Extra attention is needed

Comments

@LadnerJonas
Copy link
Owner

LadnerJonas commented Dec 15, 2021

Homework Number: W08H01

Citation of the homework instruction:

static Path solveMazeFrom(Maze maze, Position position):
[....]
Sollte ein solcher Pfad nicht mehr existieren, soll null zurückgegeben werden.

Additional Information:

Maze
[....]
du kannst aber davon ausgehen, dass der exit immer vom entrance aus erreichbar ist.

Position can be != Entrance, and thus, this case has to be tested aswell.
#33

Thanks @mani 🏅

@LadnerJonas LadnerJonas linked a pull request Dec 15, 2021 that will close this issue
2 tasks
@0xReself
Copy link
Contributor

I would agree, the instruction describes what do do with not valid positions for solving the maze. So we need to handle the case of position != entrance. And some test for that would be great!

Also here the link for the zulip post im getting my information from:
https://zulip.in.tum.de/#narrow/stream/864-PGdP-W08H01--.20Rekursive.20Pfade/topic/Null.20Eingaben

@LadnerJonas LadnerJonas changed the title Missing Test: solveMazeFrom impossible path from position to exit W08H01: Missing Test: solveMazeFrom impossible path from position to exit Dec 16, 2021
@LadnerJonas LadnerJonas added the help wanted Extra attention is needed label Dec 16, 2021
@YannickWiest
Copy link

YannickWiest commented Dec 16, 2021

Also a test for the case: "going over the entrance" needs to be added i think. Because i think i read that it is possible for a solution path to start somewhere at the top and then cross the entrance on its way down.

WWW
WPW
W W
WEW
W W
WXW

In this case P marks the starting point. I think therfore the valid solution should be 4*Dow
Correct me if im wrong

I will try to find the corresponding Zulip Post tomorrow.
I will also try to create a test and upload it by then if i somehow figure out how to do that^^

@LadnerJonas
Copy link
Owner Author

LadnerJonas commented Dec 16, 2021

Yeah a zulip link would be great. 👍
Just asked the so-called Übungsleitung: This is a valid maze and we need to be able to solve it.

@YannickWiest
Copy link

If this still needs to be converted into a test by tomorrow I will do so.

@LadnerJonas
Copy link
Owner Author

I am working on it. 🚀

@LadnerJonas LadnerJonas linked a pull request Dec 16, 2021 that will close this issue
2 tasks
@LadnerJonas
Copy link
Owner Author

Can be closed @YannickWiest @0xReself?

@0xReself
Copy link
Contributor

Yeah great work looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
3 participants