Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Travis caching #6

Merged
merged 1 commit into from
Sep 14, 2015
Merged

Refactored Travis caching #6

merged 1 commit into from
Sep 14, 2015

Conversation

pamil
Copy link
Member

@pamil pamil commented Sep 14, 2015

  • Changed custom cache directory from $HOME/.mink-log-cache to $HOME/.mink-debug-cache
  • This path is available as environmental variable $CACHE_DIR

@@ -1,11 +1,15 @@
language: php

env:
global:
- CACHE_DIR=$HOME/.mink-debug-cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CACHE_DIR is very general, maybe something more specific MINK_DEBUG_CACHE_DIR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is supposed to be general, what do you think about $TRAVIS_CACHE_DIR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 But then, maybe we should rename the default folder, right? On the other hand, we don't want to conflict with travis cache some day.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you mean by the default folder. $PROJECT_CACHE_DIR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, if we call it TRAVIS_CACHE_DIR, then its default name should not be .mink-debug-cache, agree? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's stick to MINK_DEBUG_CACHE_DIR, it's quite long, but SYLIUS_CACHE_DIR makes sense in Sylius.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite long, but there is a small possibility someone uses this name somewhere else.

pjedrzejewski pushed a commit that referenced this pull request Sep 14, 2015
Refactored Travis caching
@pjedrzejewski pjedrzejewski merged commit 2b7e62b into master Sep 14, 2015
@pjedrzejewski
Copy link
Contributor

👍

@pamil pamil deleted the cache-dir branch September 14, 2015 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants