-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Travis caching #6
Conversation
@@ -1,11 +1,15 @@ | |||
language: php | |||
|
|||
env: | |||
global: | |||
- CACHE_DIR=$HOME/.mink-debug-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CACHE_DIR
is very general, maybe something more specific MINK_DEBUG_CACHE_DIR
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is supposed to be general, what do you think about $TRAVIS_CACHE_DIR
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 But then, maybe we should rename the default folder, right? On the other hand, we don't want to conflict with travis cache some day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean by the default folder. $PROJECT_CACHE_DIR
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, if we call it TRAVIS_CACHE_DIR
, then its default name should not be .mink-debug-cache
, agree? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's stick to MINK_DEBUG_CACHE_DIR
, it's quite long, but SYLIUS_CACHE_DIR
makes sense in Sylius.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite long, but there is a small possibility someone uses this name somewhere else.
Refactored Travis caching
👍 |
$HOME/.mink-log-cache
to$HOME/.mink-debug-cache
$CACHE_DIR