Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2 Allow building of ISO via Vagrant VM. Updating README #3

Merged
merged 1 commit into from Oct 4, 2016

Conversation

hferentschik
Copy link
Member

No description provided.

@hferentschik hferentschik changed the title Issue #2 Allow building of ISO via VAgrant VM. Updating README Issue #2 Allow building of ISO via Vagrant VM. Updating README Oct 3, 2016
end

config.vm.provision "shell", inline: <<-SHELL
sudo yum install -y @"Development Tools" rpm-build gcc-c++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hferentschik Why do we need @devlopment Tools rpm-build gcc-c++ ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not required. I took this from another setup where I need it. I think I remove rpm-build and gcc-c++. Might make sense to keep @development Tools, since it contains some tools which are handy to have on the VM, eg git.

@LalatenduMohanty
Copy link
Member

@hferentschik May be we should add a reference to https://github.com/rhinstaller/pykickstart/blob/master/docs/kickstart-docs.rst, for users who are not familiar with Kickstart files.

@hferentschik
Copy link
Member Author

May be we should add a reference to https://github.com/rhinstaller/pykickstart/blob/master/docs/kickstart-docs.rst, for users who are not familiar with Kickstart files.

+1, I pushed an update with some Vagrantfile and README updates.

@LalatenduMohanty
Copy link
Member

@hferentschik thanks.

@LalatenduMohanty LalatenduMohanty merged commit 4321a25 into minishift:master Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants