Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the dropped torch item showing light through blocks #58

Closed
piemanau opened this issue Mar 2, 2021 · 3 comments
Closed

Issue with the dropped torch item showing light through blocks #58

piemanau opened this issue Mar 2, 2021 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@piemanau
Copy link

piemanau commented Mar 2, 2021

The torch items light can go through blocks

Steps to reproduce the behavior:

  1. Get a torch
  2. Drop it in a concealed area

It shouldn't show any light at all like when you place it down inside the cube.

image
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Minecraft 1.16.5
  • Fabric Loader version 0.11.2
  • Mods [e.g. fabric-api v0.25.1+build.416-1.16, lambdynamiclights v1.3.2, modmenu v1.14.6+build.31]
    image
  • Version [e.g. 1.3.2] ?
  • Branch [e.g. mc1.16] ?
@piemanau piemanau added the bug Something isn't working label Mar 2, 2021
@LambdAurora LambdAurora added the wontfix This will not be worked on label Mar 2, 2021
@LambdAurora
Copy link
Owner

Performances are already bad, fixing this issue would worsen the performances more.

@piemanau
Copy link
Author

piemanau commented Mar 2, 2021

Ah ok cool

@bernards934
Copy link

Hello, I saw a similar feature on Lucent mod (on Forge Loader) and it was not that bad in term of performances.
Do you think this feature could maybe still be implemented behind a setting to toggle it ON or OFF ?
Doing it that way would ensure people can disable it in case of huge performance drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants