Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-react-router #6

Merged
merged 2 commits into from Nov 7, 2018
Merged

add-react-router #6

merged 2 commits into from Nov 7, 2018

Conversation

JJAshcraft
Copy link
Contributor

@JJAshcraft JJAshcraft commented Nov 7, 2018 •
edited

Description

Added React Router imports to index.js, wrapped App component, and added test route to app.js

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Route tested manually at 'http://localhost:3000/landing'

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code has been reviewed by at least one peer
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Serrowxd Serrowxd merged commit 13647f6 into master Nov 7, 2018
@Serrowxd Serrowxd deleted the add-react-router branch November 7, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlinehan tlinehan tlinehan approved these changes

@Serrowxd Serrowxd Awaiting requested review from Serrowxd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JJAshcraft @tlinehan @Serrowxd