Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload image fix #88

Merged
merged 4 commits into from Feb 3, 2020
Merged

Upload image fix #88

merged 4 commits into from Feb 3, 2020

Conversation

MWeber313
Copy link
Collaborator

Description

Allows for an array of images to be uploaded to Cloudinairy/our database

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Change Status

  • Complete, tested, ready to review and merge

How Has This Been Tested?

-Manually

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code has been reviewed by at least one peer
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

MWeber313 and others added 4 commits January 29, 2020 14:18
@MWeber313 @Memitaru
Switched multiple to true
5ce3e09 
Co-authored-by: Dave Inden <davidinden@gmail.com> Co-authored-by: Ian Schwartz <ian.schwartz23@gmail.com> Co-authored-by: Grissobel Payonk <grissobel.castro@gmail.com> Co-authored-by: Jason Loomis <jason@jrloomis.com> Co-authored-by: Ami Scott <amiezrascott@gmail.com>
@MWeber313 @gspayonk
You can now add multiple files to an image upload.
dd643db 
Co-authored-by: Dave Inden <davidinden@gmail.com> Co-authored-by: Ian Schwartz <ian.schwartz23@gmail.com> Co-authored-by: Grissobel Payonk <grissobel.castro@gmail.com>
@MWeber313 @Memitaru
Attempting to fix upload issue. Please do not merge.
0faa7e7 
Co-authored-by: Dave Inden <davidinden@gmail.com> Co-authored-by: Ian Schwartz <ian.schwartz23@gmail.com> Co-authored-by: Grissobel Payonk <grissobel.castro@gmail.com> Co-authored-by: Jason Loomis <jason@jrloomis.com> Co-authored-by: Ami Scott <amiezrascott@gmail.com>
@MWeber313 @daveskull81
@ian-schwartz @gspayonk @jrloom @Memitaru
Fixed upload on submission branch to allow for an array of images
2f7b9a4 
Co-authored-by: Dave Inden <davidinden@gmail.com>
Co-authored-by: Ian Schwartz <ian.schwartz23@gmail.com>
Co-authored-by: Grissobel Payonk <grissobel.castro@gmail.com>
Co-authored-by: Jason Loomis <jason@jrloomis.com>
Co-authored-by: Ami Scott <amiezrascott@gmail.com>
@MWeber313 MWeber313 requested a review from jrloom February 3, 2020 20:41
daveskull81
daveskull81 approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@daveskull81 daveskull81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this built out over zoom. It should be good to merge.

jrloom
jrloom approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@jrloom jrloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw most of this in Zoom. Looks good to merge.

ian-schwartz
ian-schwartz approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@ian-schwartz ian-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this bug fixed live, good to merge.

@MWeber313 MWeber313 merged commit aedc940 into master Feb 3, 2020
@daveskull81
Copy link
Collaborator

Unable to add multiple photos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveskull81 daveskull81 daveskull81 approved these changes

@jrloom jrloom jrloom approved these changes

@gspayonk gspayonk gspayonk approved these changes

@ian-schwartz ian-schwartz ian-schwartz approved these changes

@Memitaru Memitaru Awaiting requested review from Memitaru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MWeber313 @daveskull81 @jrloom @gspayonk @ian-schwartz @Memitaru