Non zero exit code on error #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fail fast when erorr occurs and directly report it to the operator - Instanciate a new fsi session for every build as otherwise types would be reloaded to the sessions and be incompatible with each other in watch mode - Handle obvious exceptions in order for watch mode to continue
|
@jeremyabbott I think I should have condensed your work, my original draft and the content of our discussion in #28 down to the needed changes with the last commit. What do you think, can we open this up for a review? |
|
@jeremyabbott are you still working on something on your side? Otherwise I'd just open this up to be reviewed by Chris. |
|
Thanks a lot! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to implement this to address #20. I'm trying to insert an additional piece of information in the process of creating files in the
_publicfolder. For lack of a better term I typed them asGeneratorResults. I'm still not entirely happy so I leave this as a draft and will play around with the concept for the next couple of evenings (whenever I have time).I'd be always happy to receive feedback as this might open up the field for a couple of changes.