Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the long Content.ModeKind texts into lines #283

Closed
Mikolaj opened this issue Nov 15, 2021 · 5 comments
Closed

Split the long Content.ModeKind texts into lines #283

Mikolaj opened this issue Nov 15, 2021 · 5 comments

Comments

@Mikolaj
Copy link
Member

Mikolaj commented Nov 15, 2021

both in LambdaHack and Allure. Currently the lines are divided by \n characters, but they are more readable presented as at

https://github.com/AllureOfTheStars/Allure/blob/3315a7195e27ed28a735841c61ee1f412ce99002/GameDefinition/Content/ModeKind.hs#L111

so this should be extended to each text in this file and its LambdaHack counterpart.

This is as easy issue as fixing typos, but improves readability and even automatic spell-checking a lot.

@kayvank
Copy link
Contributor

kayvank commented Mar 7, 2022

@Mikolaj was this implemented? I'd like to start contributing and am looking for my first issue. Any suggestion is appreciated.

@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 7, 2022

@kayvank: hi! No, it was only implemented in a few texts. Let me know if I can guide you in setting up a fork with a proper cabal.project.local (as in README), creating a PR, etc. Matrix or Discord is probably the best place to chat about such things, but tickets are fine, too, especially about specific ticket-related topics.

@Mikolaj Mikolaj closed this as completed in 8df4d86 Mar 8, 2022
@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 8, 2022

Done in LambdaHack. Only the Allure part remains now.

@kayvank
Copy link
Contributor

kayvank commented Mar 10, 2022

@Mikolaj Here is the PR-117 for Allure related work.

@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 10, 2022

Fixed in AllureOfTheStars/Allure#117. Closing

@Mikolaj Mikolaj closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants