Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LambdaTest run command doesn't exit with code "1" when ran into an error #305

Open
dcodesdev opened this issue Feb 16, 2024 · 2 comments · May be fixed by #306
Open

LambdaTest run command doesn't exit with code "1" when ran into an error #305

dcodesdev opened this issue Feb 16, 2024 · 2 comments · May be fixed by #306

Comments

@dcodesdev
Copy link

I'm running lambdatest-cypress run when it runs into an error it exits with code 0 instead of 1.

I'm using it as a part of CI/CD pipeline, so when the command runs I want it to exit with status code 1 so that it marks my CI pipeline as failed.

@dcodesdev dcodesdev linked a pull request Feb 17, 2024 that will close this issue
@HRanjan-11
Copy link
Collaborator

HRanjan-11 commented Feb 18, 2024

@Dawsoncodes do you want the cli to be exited with code 1 when the test fails?

@dcodesdev
Copy link
Author

Not the tests necessarily.

I want the command run to exit with 1 if for example if the lambdatest-config.json wasn't available.

Basically, when the tests don't get uploaded to LT, I want it to exit with 1, right now it exits with 0 and when ran in CI/CD pipelines, the pipeline will be marked as success even though it has errored because the exit code was 0

I already created a PR which fixes the issue, I'm hoping it gets merged soon. #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants