Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge init and connect Broker arguments #14

Closed
Lancetnik opened this issue May 19, 2023 · 0 comments
Closed

Merge init and connect Broker arguments #14

Lancetnik opened this issue May 19, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Lancetnik
Copy link
Owner

Need to replace logic there to merge __init__ and connect arguments to one kwargs. Connect args should has priority to replace default init args.

Expectred behavior:

from propan import RabbitBroker

broker = RabbitBroker(host="localhost", port=6379")

...
    await broker.connect(host="127.0.0.1")  # connects to 127.0.0.1:6379
@Lancetnik Lancetnik added the good first issue Good for newcomers label May 19, 2023
@Lancetnik Lancetnik changed the title Megre init and connect Broker arguments Merge init and connect Broker arguments Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant