Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking request parameters #51

Closed
cbl opened this issue May 4, 2021 · 4 comments · Fixed by #52
Closed

Tracking request parameters #51

cbl opened this issue May 4, 2021 · 4 comments · Fixed by #52

Comments

@cbl
Copy link
Contributor

cbl commented May 4, 2021

Hi, everyone! I wondered if there is a reason why the request parameters are not logged. This can be very usefull in some cases. (Would do a pr if this would be accepted)

@Cannonb4ll
Copy link
Contributor

Mainly because of sensitive data we do not want to be responsible off which lands in our database.

If you have a way to filter out all the sensitive data the PR is more than welcome.

@cbl
Copy link
Contributor Author

cbl commented May 4, 2021

Aren't headers sensitive in the same way? 🤔

I think a good way to filter sensitive data within request parameters is to filter parameters whose name contains words like password, pw, pwd, ... and also give the user the option to filter additional parameters.

Same thing with headers (if this is not the case already), headers like Authorization and other known token headers should be filtered by default with the option to filter additional headers.

@Cannonb4ll
Copy link
Contributor

They certainly are, but less common to contain user data that gets sent over.

That being said, you could recycle the blacklist so the user itself has control over this, this list is being used when receiving headers

Config:
https://github.com/LaraBug/LaraBug/blob/master/config/larabug.php#L88

Function to filter:

public function filterVariables($variables)

A PR is welcome for this 😎

@cbl
Copy link
Contributor Author

cbl commented May 4, 2021

Will create a pr when I find the time, I could have needed this in a view cases for debugging already 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants