New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Why does v6 provide a Source Sans Pro CSS file? #5168

Closed

tabacitu opened this issue Jul 2, 2023 · 1 comment

Labels

Minor Bug Priority: SHOULD Size: XS triage

Member

tabacitu commented Jul 2, 2023

I'm doing the final v6 review before launch and here's I've found we have this file in CRUD - https://github.com/Laravel-Backpack/CRUD/pull/4860/files#diff-b8497ece9029a90ddf503d37dc19006c79c9e5319d193354f82cdcd942b40ce3

Afaik:

CoreUIv2 uses Source Sans Pro
CoreUIv4 might use Source Sans Pro
Tabler uses Inter

But any way you take it... it shouldn't be CRUD providing the Source Sans Pro CSS file... it should be the theme that uses it... right?

tabacitu added triage Priority: SHOULD Minor Bug labels

tabacitu added the Size: XS label

Contributor

pxpm commented Jul 14, 2024

I could not replicate this issue. I couldn't find source sans pro in crud repository.

Closing, re-open if needed.

pxpm closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment