Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on install command #19

Closed
jiaojie1989 opened this issue Jan 6, 2022 · 1 comment
Closed

Improvement on install command #19

jiaojie1989 opened this issue Jan 6, 2022 · 1 comment

Comments

@jiaojie1989
Copy link

In file https://github.com/Laravel-Backpack/FileManager/blob/master/src/Console/Commands/Install.php line 59

        $this->line(' Publishing elFinder assets');
        $this->executeProcess(['php', 'artisan', 'elfinder:publish']);

It's better use executeArtisanProcess instead of executeProcess, for there exists differences between environments of users, the command php may refer to another bin file than the running one.

Improvement:

        $this->executeArtisanProcess('elfinder:publish');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants