Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Icons/Font #43

Closed
arb362 opened this issue Oct 27, 2023 · 2 comments · Fixed by #44
Closed

Missing Icons/Font #43

arb362 opened this issue Oct 27, 2023 · 2 comments · Fixed by #44

Comments

@arb362
Copy link
Contributor

arb362 commented Oct 27, 2023

Problem
elFinder Material Theme recently updated to v3.0.0 and in doing so they moved the font from the icons subfolder to the font folder.

image
See this commit
As a result when basset caches everything it misses this and you receive a 404 error and no icons.

Solution
The common_styles.blade will need updated.

Oddly enough, Basset still caches the font file from jsdelivr. I'm assuming that because there is not a specific version specified in the url jsdelivr serves up the last version that has that file?

@rk
Copy link

rk commented Oct 27, 2023

I can confirm that we are also affected by this issue.

Maybe the specific version should be pinned on these assets and manually checked/updated in the theme? This would prevent breaking changes from going untested.

@karandatwani92
Copy link

Discussion continued on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants