Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the "getBest..." methods to "getWinning..." #7

Open
LarsGast opened this issue Oct 15, 2023 · 0 comments
Open

Rename the "getBest..." methods to "getWinning..." #7

LarsGast opened this issue Oct 15, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@LarsGast
Copy link
Owner

The method PokerHand.getBestHand() already exists to get the best hand based on a list of cards. The PokerHand.getWinningHand() method gets the winning hand among a list of PokerHands. This method calls other methods with names like getBestStraightFlush() and getBestTwoPair(). For consistency, these methods should be called getWinningStraightFlush() and getWinningTwoPair().

Since these methods are private, the interface of the NuGet package will not change.

@LarsGast LarsGast added the documentation Improvements or additions to documentation label Oct 15, 2023
@LarsGast LarsGast added this to the Version 1.0.1 milestone Oct 15, 2023
@LarsGast LarsGast self-assigned this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant