Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command #8

Open
LarsWiegers opened this issue Mar 18, 2022 · 2 comments
Open

Fix command #8

LarsWiegers opened this issue Mar 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@LarsWiegers
Copy link
Owner

LarsWiegers commented Mar 18, 2022

The idea:

Include an --fix option that fixes the problems we find.
Scenario:
lang/

  • nl/
  • actions.php
  • en/
  • actions.php

Lets say that both actions.php have this content:
'save' => 'save',

But the en version also has:
'saving' => 'saving',

But the nl version is missing it.

This would, of course, be caught by the check command, but what if it asks you to type the translation for the missing

translations if you use the --fix flag.

What do you want for the translation for nl (actions.php) 'saving' => 'saving' (en version) to be?

Where what you entered will be added to the nl version of the acitons.php file.

Or something like that. Would that be useful?

@mikewink
Copy link

Hello Lars,

for a "quick fix" and where the key value pair is expressive/short enough to know what's going on, yes!

For many fixes I would rather do it the old fashioned way. Maybe automatically add the missing keys at the end of the file in question / or create the missing file with the keys? That could be very helpful to jump start corrections too.

@LarsWiegers
Copy link
Owner Author

Hi Mike,

Thx for the comment. I totally agree with you.
I am currently very busy but I will take a crack at this somepoint in the future.

@LarsWiegers LarsWiegers added the enhancement New feature or request label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants