Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LatencyStats#stop() shuts down static executor? #7

Open
marshallpierce opened this issue Jan 15, 2015 · 0 comments
Open

LatencyStats#stop() shuts down static executor? #7

marshallpierce opened this issue Jan 15, 2015 · 0 comments

Comments

@marshallpierce
Copy link

Just reading through the code to figure out how it works, and I noticed https://github.com/LatencyUtils/LatencyUtils/blob/master/src/main/java/org/LatencyUtils/LatencyStats.java#L307. Is this intentional that shutting down one LatencyStats will halt that shared executor? It's hard to tell the intent because TimeServices.ScheduledExecutor#scheduleAtFixedRate is not actually used (presumably it's there as a convenience for other user code).
mp911de referenced this issue in redis/lettuce Apr 26, 2017
@mp911de
Stop LatencyStats on removal #517
1a6362f 
Lettuce now stops LatencyStats when removing the object from latency collection scope. Stopping LatencyStats unregisters from the associated PauseDetector and removes listener resources so GC can remove the object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marshallpierce