Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aa): ship generated types #638

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat(aa): ship generated types #638

merged 1 commit into from
Oct 5, 2023

Conversation

boneskull
Copy link
Contributor

This ships declaration files for @lavamoat/aa.

  • added @types/resolve for types from resolve
  • remove some dead code; canonicalNameMap didn't need to be passed to walkDependencyTreeForBestLogicalPaths
  • maybe fixed a bug in signature for walkDependencyTreeForBestLogicalPaths where performantResolve was undefined (or pulled out of global scope??)

@boneskull
Copy link
Contributor Author

boneskull commented Jul 31, 2023 •
edited

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@boneskull boneskull self-assigned this Jul 31, 2023
@boneskull boneskull added the enhancement New feature or request label Jul 31, 2023
This was referenced Sep 1, 2023
Merged
Merged
Base automatically changed from boneskull/ts to main October 5, 2023 17:58
@boneskull
feat(aa): ship generated types
8945c98 
This ships declaration files for `@lavamoat/aa`.

- added [@types/resolve](https://npm.im/@types/resolve) for types from [resolve](https://npm.im/resolve)
- remove some dead code; `canonicalNameMap` didn't need to be passed to `walkDependencyTreeForBestLogicalPaths`
- maybe fixed a bug in signature for `walkDependencyTreeForBestLogicalPaths` where `performantResolve` was `undefined` (or pulled out of global scope??)
@boneskull boneskull merged commit d8d5996 into main Oct 5, 2023
11 checks passed
@boneskull boneskull deleted the boneskull/ts-aa branch October 5, 2023 19:57
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naugtur naugtur naugtur approved these changes

@legobeat legobeat legobeat approved these changes

Assignees

@boneskull boneskull

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boneskull @legobeat @naugtur