Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Courses not using "COURSE" offer #12

Closed
house92 opened this issue Sep 4, 2018 · 1 comment
Closed

Courses not using "COURSE" offer #12

house92 opened this issue Sep 4, 2018 · 1 comment

Comments

@house92
Copy link

house92 commented Sep 4, 2018

It seems that the majority of your courses are actually using the offer with identifier "SINGLE" to provide their price, when it seems this ought to be the "COURSE" offer. We only noticed this because one course correctly provide their price through the "COURSE" offer. There is yet another which provides no price in either. Please see the below examples as a reference:

[
  {
    "name": "Tennis Tuesdays Course",
    "offer": [
      {
        "type": "Offer",
        "price": 0,
        "priceCurrency": "GBP",
        "identifier": "COURSE",
        "name": "Full course"
      },
      {
        "type": "Offer",
        "price": 100,
        "priceCurrency": "GBP",
        "identifier": "SINGLE",
        "name": "Single session"
      },
      {
        "type": "Offer",
        "price": 0,
        "priceCurrency": "GBP",
        "eligibleCustomerType": "Member",
        "identifier": "SINGLE-MEMBER",
        "name": "Single session (Member)"
      }
    ]
  },
  {
    "name": "Tennis Tuesdays Course",
    "offer": [
      {
        "type": "Offer",
        "price": 0,
        "priceCurrency": "GBP",
        "identifier": "COURSE",
        "name": "Full course"
      },
      {
        "type": "Offer",
        "price": 145,
        "priceCurrency": "GBP",
        "identifier": "SINGLE",
        "name": "Single session"
      },
      {
        "type": "Offer",
        "price": 0,
        "priceCurrency": "GBP",
        "eligibleCustomerType": "Member",
        "identifier": "SINGLE-MEMBER",
        "name": "Single session (Member)"
      }
    ]
  },
  {
    "name": "Tennis for Kids Course",
    "offer": [
      {
        "type": "Offer",
        "price": 0,
        "priceCurrency": "GBP",
        "identifier": "COURSE",
        "name": "Full course"
      },
      {
        "type": "Offer",
        "price": 0,
        "priceCurrency": "GBP",
        "identifier": "SINGLE",
        "name": "Single session"
      }
    ]
  },
  {
    "name": "Tennis for Kids Course",
    "offer": [
      {
        "type": "Offer",
        "price": 25,
        "priceCurrency": "GBP",
        "identifier": "COURSE",
        "name": "Full course"
      },
      {
        "type": "Offer",
        "price": 0,
        "priceCurrency": "GBP",
        "eligibleCustomerType": "Member",
        "identifier": "COURSE-MEMBER",
        "name": "Full course (Member)"
      },
      {
        "type": "Offer",
        "price": 0,
        "priceCurrency": "GBP",
        "identifier": "SINGLE",
        "name": "Single session"
      }
    ]
  }
]

We will put a hack in place to try to catch such instances, but it would be great if you could fix this.

@peter-dolkens
Copy link
Member

Resolved in upcoming release

@house92 house92 closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants