Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxBufferSize in libember_slim/Source/__sample_provider.c #62

Open
DHDaudio-support opened this issue Apr 7, 2017 · 1 comment
Open
Labels
Component-LibEmberSlim Issues relating to the libember_slim library. Kind-Bug

Comments

@DHDaudio-support
Copy link

For those who are using libember_slim as is (with the sample code), there might be an issue for providers when receiving multi-paket messages with the maximum possible payload of 1024 bytes (see also Lawo/ember-plus-sharp#42).

The rxBufferSize in in https://github.com/Lawo/ember-plus/blob/master/libember_slim/Source/__sample_provider.c is set to 1024 - but as far as we see it should also be minimum 1290 in order to handle Ember+ packets with maximum payload correctly.

In comparison see that the rxBufferSize in the https://github.com/Lawo/ember-plus/blob/master/libember_slim/Source/__sample_consumer.c is set to 1290.

@KimonHoffmann
Copy link
Contributor

Good spot, thank you!
Could you submit a pull request correcting this?

@KimonHoffmann KimonHoffmann added the Component-LibEmberSlim Issues relating to the libember_slim library. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-LibEmberSlim Issues relating to the libember_slim library. Kind-Bug
Projects
None yet
Development

No branches or pull requests

2 participants