Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@layerzerolabs/lz-evm-oapp-v2 uses dependency with outdated ethers@5 peer dependency #22

Open
actuallymentor opened this issue Feb 5, 2024 · 2 comments

Comments

@actuallymentor
Copy link

When installing @layerzerolabs/lz-evm-oapp-v2 with the latest hardhat, one encounters a peer dependency conflct.

It looks like layerzerolabs/lz-evm-oapp-v2 depends on @layerzerolabs/lz-evm-messagelib-v2, which depends on @eth-optimism/contracts@"^0.6.0, which depends on ethers@5.7.2.

While this error can be ignored with --legacy-peer-deps it is probably a good idea to fix the underlying dependencies or add this to a Known Issues section so as to not confuse/worry developers trying out the oApp contracts.

Dependency issue trace:

npm ERR! While resolving: hardhat-project@0.1.0
npm ERR! Found: ethers@6.10.0
npm ERR! node_modules/ethers
npm ERR!   peer ethers@"^6.1.0" from @nomicfoundation/hardhat-chai-matchers@2.0.4
npm ERR!   node_modules/@nomicfoundation/hardhat-chai-matchers
npm ERR!     peer @nomicfoundation/hardhat-chai-matchers@"^2.0.0" from @nomicfoundation/hardhat-toolbox@4.0.0
npm ERR!     node_modules/@nomicfoundation/hardhat-toolbox
npm ERR!       dev @nomicfoundation/hardhat-toolbox@"^4.0.0" from the root project
npm ERR!   peer ethers@"^6.1.0" from @nomicfoundation/hardhat-ethers@3.0.5
npm ERR!   node_modules/@nomicfoundation/hardhat-ethers
npm ERR!     peer @nomicfoundation/hardhat-ethers@"^3.0.0" from @nomicfoundation/hardhat-chai-matchers@2.0.4
npm ERR!     node_modules/@nomicfoundation/hardhat-chai-matchers
npm ERR!       peer @nomicfoundation/hardhat-chai-matchers@"^2.0.0" from @nomicfoundation/hardhat-toolbox@4.0.0
npm ERR!       node_modules/@nomicfoundation/hardhat-toolbox
npm ERR!         dev @nomicfoundation/hardhat-toolbox@"^4.0.0" from the root project
npm ERR!     peer @nomicfoundation/hardhat-ethers@"^3.0.0" from @nomicfoundation/hardhat-toolbox@4.0.0
npm ERR!     node_modules/@nomicfoundation/hardhat-toolbox
npm ERR!       dev @nomicfoundation/hardhat-toolbox@"^4.0.0" from the root project
npm ERR!   3 more (@nomicfoundation/hardhat-toolbox, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! @layerzerolabs/lz-evm-oapp-v2@"*" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: ethers@5.7.2
npm ERR! node_modules/ethers
npm ERR!   peer ethers@"^5" from @eth-optimism/contracts@0.6.0
npm ERR!   node_modules/@eth-optimism/contracts
npm ERR!     peer @eth-optimism/contracts@"^0.6.0" from @layerzerolabs/lz-evm-messagelib-v2@2.0.25
npm ERR!     node_modules/@layerzerolabs/lz-evm-messagelib-v2
npm ERR!       peer @layerzerolabs/lz-evm-messagelib-v2@"^2.0.25" from @layerzerolabs/lz-evm-oapp-v2@2.0.25
npm ERR!       node_modules/@layerzerolabs/lz-evm-oapp-v2
npm ERR!         @layerzerolabs/lz-evm-oapp-v2@"*" from the root project
npm ERR!
@actuallymentor actuallymentor changed the title @layerzerolabs/lz-evm-oapp-v2Dependency with outdated ethers@5 peer dependency @layerzerolabs/lz-evm-oapp-v2 uses Dependency with outdated ethers@5 peer dependency Feb 5, 2024
@actuallymentor actuallymentor changed the title @layerzerolabs/lz-evm-oapp-v2 uses Dependency with outdated ethers@5 peer dependency @layerzerolabs/lz-evm-oapp-v2 uses dependency with outdated ethers@5 peer dependency Feb 5, 2024
@Gbanks2230
Copy link

Good suggestion

@lolipup009
Copy link

Find a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants