feat(lsp): add 'reuse_win' for reuse window in lsp definition keymap #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folke
requested changes
Jul 14, 2023
lua/lazyvim/plugins/lsp/keymaps.lua
Outdated
| @@ -5,6 +5,8 @@ M._keys = nil | |||
|
|
|||
| ---@return (LazyKeys|{has?:string})[] | |||
| function M.get() | |||
| local telescope = require("telescope.builtin") | |||
There was a problem hiding this comment.
Please inline the require, otherwise Telescope will always be loaded whenever an lsp attaches
folke
reviewed
Jul 14, 2023
| @@ -16,11 +14,11 @@ function M.get() | |||
| M._keys = { | |||
| { "<leader>cd", vim.diagnostic.open_float, desc = "Line Diagnostics" }, | |||
| { "<leader>cl", "<cmd>LspInfo<cr>", desc = "Lsp Info" }, | |||
| { "gd", function() telescope.lsp_definitions({ reuse_win = true }) end, desc = "Goto Definition", has = "definition" }, | |||
| { "gd", function() require("telescope.builtin").lsp_definitions({ reuse_win = true }) end, desc = "Goto Definition", has = "definition" }, | |||
| { "gr", "<cmd>Telescope lsp_references<cr>", desc = "References" }, | |||
There was a problem hiding this comment.
Does this also wok for lsp references?
There was a problem hiding this comment.
No, lsp references does not support the 'reuse_win' option.
dpetka2001
pushed a commit
to dpetka2001/LazyVim
that referenced
this pull request
Jul 18, 2023
…azyVim#1131) * feat(lsp): add 'reuse_win' for reuse window in lsp definition keymap * fix: inline telescope require
joshmedeski
pushed a commit
to joshmedeski/LazyVim
that referenced
this pull request
Sep 1, 2023
…azyVim#1131) * feat(lsp): add 'reuse_win' for reuse window in lsp definition keymap * fix: inline telescope require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jump to existing window if buffer is already opened when the builtin.lsp_definitions, builtin.lsp_type_definitions and builtin.lsp_implementations only return one result.
nvim-telescope/telescope.nvim#2454 (comment)