Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extras): Rust-Analyzer cargo option #3061

Merged
merged 2 commits into from
May 3, 2024
Merged

fix(extras): Rust-Analyzer cargo option #3061

merged 2 commits into from
May 3, 2024

Conversation

imzhongqi
Copy link
Contributor

I saw the official manual said this. I thought our configuration was wrong. I fixed it.
rust-analyzer manual:
https://rust-analyzer.github.io/manual.html#nvim-lsp

@dpetka2001
Copy link
Contributor

dpetka2001 commented Apr 25, 2024

I believe this should be buildScripts.enable = true. Reference here. We could either leave it as is (I don't know if the old style will get deprecated any time soon) or use the new syntax, but with the correction I suggested (unless I misunderstood something).

PS: @amaanq sorry for pinging you, but since you mentioned Rust is your daily language, I believe you're more appropriate to verify my claim or not.

@amaanq
Copy link
Contributor

amaanq commented Apr 25, 2024

yeah no worries, and you're right. it should be buildScripts.enable = true (or buildScripts = { enable = true } ?), it's probably better to stick with what r-a suggests, since they can be fast moving at times

@dpetka2001
Copy link
Contributor

Yes it should be the table syntax as you noted, I just wrote it like that for abbreviation.

@imzhongqi
Copy link
Contributor Author

I updated the commit, but I didn’t look carefully. It’s a table.

@folke folke merged commit a96348d into LazyVim:main May 3, 2024
@folke
Copy link
Collaborator

folke commented May 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants