fix(ui): don't lazy-load dashboard-nvim

[mangkoran]

As nvimdev/dashboard-nvim#450, dashboard-nvim shouldn't be lazy-loaded to properly handle stdin.

Not really sure if this is enough to make dashboard-nvim not lazy-loaded.

[rubiin]

I think that should work .
Other place which would by default enforce lazyloading would be

  defaults = {
    lazy = false, -- should plugins be lazy-loaded?

but i think its turned off by default.
Also it would be better to leave the link nvimdev/dashboard-nvim#450 as a comment on the dashboard plugin spec so as to convey the info

[mangkoran]

Thank you for the confirmation. I have updated the branch. Please kindly check :D

[rubiin]

That looks good to me :)

[baod-rate]

does it make more sense to explicitly disable lazy-loading?

     "nvimdev/dashboard-nvim",
-    event = "VimEnter",
+    lazy = false,
     opts = function()

as we do here:

LazyVim/lua/lazyvim/plugins/extras/lang/tex.lua

Lines 27 to 29 in 530e94a

	{
	"lervag/vimtex",
	lazy = false, -- lazy-loading will disable inverse search

just removing the event param causes the dashboard to not load at all if the user has require("lazy").setup({ defaults = { lazy = true }}. AFAIK no other LazyVim-plugins behave like that

[dpetka2001]

But that is not default Lazyvim behavior. Only if the user has explicitly set lazy = true in his config. That means he also has to explicitly set the lazy keyword for all the plugins that he desires a different behavior in my opinion.

[baod-rate]

Yes, I realize that lazy = true is not the default setup for lazy.nvim. But every other plugin in this repo, AFAIK, is implicitly lazy (whether through an event/keys/cmd) or explicity lazy = true/false. With this change, dashboard-nvim would be the only plugin in LazyVim whose lazy setting depends on the configured default for lazy.nvim. That means it stops working completely if the user sets { defaults = { lazy = true }.

Regardless of whether you think lazy is an acceptable default (I agree it's better to be explicit about it). There's no reason to not set lazy = false for the dashboard-nvim plugin spec (just as with lervag/vimtex spec, above). The plugin simply does not behave correctly if it is lazy-loaded. And if the user really wants, they can still override that setting in their own config.

[dpetka2001]

Sure it definitely doesn't hurt to explicitly set it to lazy = false in that case.

[mangkoran]

@baod-rate updated with your suggestion. That would make more sense :D

[folke]

Thanks