-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution Guideline and File Format Description #92
Comments
We should also provide a description of the BFM file format in the README |
Concerning the output of some Features/MonomerExtensions I would suggest to define the standard to only write out the non-trivial behavior. Lets consider the FeatureConnectionSc. The standard is that only a few monomers in the system are reactive, but we write out this property for each monomer. For my opinion it would be sufficient to only write out the reactive ones. The Read-routine for this property sets all monomers which do not appear in the bfm file to the standard value (nonreactive). |
That's fine. The FeatureSpringPotentialTwoGroups is already working like this. Does that mean we have to rewrite Feature Attributes again? |
Yes, if we decide to handle it like I suggest it,it would mean we have to revise FeatureAttributes and FeatureConnectionSc. Other Features are not affected, because they do not add any monomerExtension. |
note: typo in README in the section Contribution (programm -> program) |
note: the contribution from Vinzenz Sinapius should be added to the Authors.md file |
note: add publication |
note: add publication |
We should add a contribution guideline including our programming style, for instance member functions start with lower case letter followed by camel case style for long function names. Suggestions of important points should be collected here in the discussion.
The text was updated successfully, but these errors were encountered: