Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Guideline and File Format Description #92

Open
MartinWenge opened this issue Feb 25, 2019 · 8 comments
Open

Contribution Guideline and File Format Description #92

MartinWenge opened this issue Feb 25, 2019 · 8 comments
Milestone

Comments

@MartinWenge
Copy link
Member

We should add a contribution guideline including our programming style, for instance member functions start with lower case letter followed by camel case style for long function names. Suggestions of important points should be collected here in the discussion.

@MartinWenge
Copy link
Member Author

We should also provide a description of the BFM file format in the README

@MartinWenge MartinWenge changed the title Contribution Guideline Contribution Guideline and File Format Description Mar 29, 2019
@tonimueller
Copy link
Member

tonimueller commented May 14, 2019

Concerning the output of some Features/MonomerExtensions I would suggest to define the standard to only write out the non-trivial behavior. Lets consider the FeatureConnectionSc. The standard is that only a few monomers in the system are reactive, but we write out this property for each monomer. For my opinion it would be sufficient to only write out the reactive ones. The Read-routine for this property sets all monomers which do not appear in the bfm file to the standard value (nonreactive).
Would do you think about this?

@MartinWenge
Copy link
Member Author

That's fine. The FeatureSpringPotentialTwoGroups is already working like this. Does that mean we have to rewrite Feature Attributes again?

@tonimueller
Copy link
Member

Yes, if we decide to handle it like I suggest it,it would mean we have to revise FeatureAttributes and FeatureConnectionSc. Other Features are not affected, because they do not add any monomerExtension.

@MartinWenge MartinWenge added this to the Version 2.2.0 milestone May 14, 2019
@MartinWenge
Copy link
Member Author

note: typo in README in the section Contribution (programm -> program)

@MartinWenge
Copy link
Member Author

note: the contribution from Vinzenz Sinapius should be added to the Authors.md file

@MartinWenge
Copy link
Member Author

note: add publication
Dendrimers in solution of linear polymers
some more publications made with LeMonADE?

@MartinWenge
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants