Move caret when number changes length #8

Merged
merged 1 commit into from Apr 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

gilliandugay commented Apr 4, 2012

This fixes the scenario described in issue #3. This ensures that the number can be incremented/decremented successively.

Owner

LeaVerou commented Apr 5, 2012

Hi there,

Thanks for the pull request!

Have you tested that it works?

Contributor

gilliandugay commented Apr 5, 2012

I've tested this on the latest versions of Firefox and Chrome.

Slightly off-topic: I've noticed Firebug outputs an error "me.checkModifiers is not a function" in the event listener. Is this a function from an older version of the code?

Thanks. :)

LeaVerou added a commit that referenced this pull request Apr 5, 2012

Merge pull request #8 from gilliandugay/master
Move caret when number changes length

@LeaVerou LeaVerou merged commit 6bda62a into LeaVerou:master Apr 5, 2012

Owner

LeaVerou commented Apr 5, 2012

Yes, it should be removed, but who has the time...

Anyway, pull request merged! thanks!

Owner

LeaVerou commented Apr 17, 2012

Code is now live. I also fixed the checkModifiers bug.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment