Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carbon #211

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Add Carbon #211

merged 3 commits into from
Aug 27, 2022

Conversation

sayzlim
Copy link
Contributor

@sayzlim sayzlim commented Aug 26, 2022

This is a new PR with the same purpose as this PR: #195

@sayzlim
Copy link
Contributor Author

sayzlim commented Aug 26, 2022

@LeaVerou this one should be okay now. Please review and let me know if I need to change anything else.

@LeaVerou
Copy link
Member

Hi @sayzlim, thank you! I think I would prefer it closer to the right side of the viewport on large screens, rather than right next to the content. Would you be able to make this change?

Move it to the right edge of the viewport.
@sayzlim
Copy link
Contributor Author

sayzlim commented Aug 26, 2022

@LeaVerou all set! Please review again.

@LeaVerou LeaVerou merged commit 74da04a into color-js:main Aug 27, 2022
@LeaVerou
Copy link
Member

Fantastic, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants