Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The previewer shown by the text cursor is not persistent #14

Closed
kizu opened this issue Dec 11, 2011 · 9 comments
Closed

The previewer shown by the text cursor is not persistent #14

kizu opened this issue Dec 11, 2011 · 9 comments
Assignees

Comments

@kizu
Copy link
Collaborator

kizu commented Dec 11, 2011

If you show the previewer when the text cursor is on the value, then it would be nice not to hide it when you move the mouse cursor over and out of it.

And if you hover the mouse over another value, you must show it's previewer, but if you move he mouse out of it, then, after you hide the previewer from the hovered value, you must show it again over the one where the cursor stands.

@ghost ghost assigned LeaVerou Dec 12, 2011
@LeaVerou
Copy link
Owner

Should be fixed now, thanks!

@kizu kizu reopened this Dec 12, 2011
@kizu
Copy link
Collaborator Author

kizu commented Dec 12, 2011

Well, it's a bit fixed, but the other bug occured, it appears that the previewer stops to be shown on hover at some moment. It's a little hard to explain in few words, so I recorded a little screencast :)

@LeaVerou
Copy link
Owner

Damn. I noticed that an hour ago but was hoping it was random. Could you please create a new bug report, as it's probably different from this one?

@kizu
Copy link
Collaborator Author

kizu commented Dec 12, 2011

Ok, done: #18, I'll close this one then.

@kizu kizu closed this as completed Dec 12, 2011
@kizu kizu reopened this Dec 15, 2011
@kizu
Copy link
Collaborator Author

kizu commented Dec 15, 2011

There is still something left:

And if you hover the mouse over another value, you must show it's previewer, but if you move he mouse out of it, then, after you hide the previewer from the hovered value, you must show it again over the one where the cursor stands

Here is a video showing this case.

@LeaVerou
Copy link
Owner

I had thought about that myself but didn't think I could make it before release. However, I think I did! Can you check please?

@kizu
Copy link
Collaborator Author

kizu commented Dec 15, 2011

Oh, it become ok when using the keyboard, but still somewhat buggy when I place the cursor by trackpad, here is a video. Though, it's better now, so this issue can wait for fixing after release I think.

@LeaVerou
Copy link
Owner

I can't see the video, however I made big changes to the code for the previewers and it seems that these issues are fixed. Please confirm.

@kizu
Copy link
Collaborator Author

kizu commented Dec 19, 2011

Oh, it's fixed now, yay!

@kizu kizu closed this as completed Dec 19, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants