Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dppx value shown on dpi.lv is misleading when not defined in screens.json #64

Open
jjagoda opened this issue Apr 24, 2014 · 2 comments
Open

Comments

@jjagoda
Copy link

jjagoda commented Apr 24, 2014

When the dppx value is not defined in screens.json the value shown on dpi.lv is equal to 1 which is misleading.

Example:

{
"name": "Google Nexus 5",
"w": 1920,
"h": 1080,
"d": 4.95
}

and then the table "Known screens" on dpi.lv shows:

Name Diagonal Resolution DPI dppx
Google Nexus 5 4.95″ 1920×1080 445 1

When dppx is unknown it should be reflected in the table as for Nexus 5 it is 3, not 1.

@CatherineLiyuankun
Copy link

Samsung Galaxy S7 dppx is 1 is not right

@arkon
Copy link
Collaborator

arkon commented Mar 23, 2017

PRs for corrected dppx values would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants