Event propagation is stopped when default is prevented

[JavierParra]

When intercooler prevents the default behaviour it also stops propagation (by returning false to the jQuery event handler) therefore preventing any further use my application could have for that event.

[1cg]

I'm wondering if the fix for this will have unintended consequences for existing users. What do you think?

[JavierParra]

I can see someone declaring a document-wide click handler for something else and relying on it not being propagated for intercooler links.

But in that scenario, they'd encounter unexpected behavior when not setting an "href" attribute and also it'd be easy for them to check if the element that initiated the event is an ic link.

I agree it has a chance to break someone's code but I do believe it's important to have homogeneous behavior and not break a standard API.

Maybe add a "breaking changes" notice in the changelog?

[1cg]

Mmm. Let me think about it a few days. Another option would be to make it an, er, option, via a configuration attribute or meta tag... Mmm. On December 28, 2016 at 11:34:32 AM, JavierParra (notifications@github.com) wrote: I can see someone declaring a document-wide click handler for something else and relying on it not being propagated for intercooler links. But in that scenario, they'd encounter unexpected behavior when not setting an "href" attribute. I agree it has a chance to break someone's code but I do believe it's important to have homogeneous behavior and not break a standard API. Maybe add a "breaking changes" notice in the changelog? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#150 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcov8VSd1_ApmQbnasvZ8CZ3eY8RGUFks5rMrnIgaJpZM4LSOwd> .