Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable all tooltips #194

Closed
Zverik opened this issue Sep 30, 2013 · 3 comments
Closed

Add an option to disable all tooltips #194

Zverik opened this issue Sep 30, 2013 · 3 comments

Comments

@Zverik
Copy link
Contributor

Zverik commented Sep 30, 2013

Tooltips are really big and distracting, and they require translating when the plugin is used on multilingual sites. It gets worse when the plugin is used in another plugin that might be used on multilingual sites. Finally, those distance/area measurements are silly: they are hidden after a line has been drawn, and not displayed when a line is edited. It's been probably added "because we can", and not for some real purpose. It should be possible to turn off such unnecessary visual stuff. Tooltips are the first to go.

@jacobtoye
Copy link
Member

Tell us what you really think...

In my opinion the tooltips are an important part of the user experience. If you don't inform the user how to use the tools, how will they know how to use them? You can configure the text via the L.drawLocal object.

The distance measurements were a specific requirement for the system I created the plugin for. They may be superfluous, but this would be the first complaint I have had regarding them. In fact, there were request to include imperial support so some people must have found them useful.

In the future I think you should consider the manner you are submitting issue reports to open source software projects. Perhaps you could be explain your requirement without being rude and aggressive. Reports like this do not encourage the maintainers to take your report seriously.

To disable tooltips you can use some simple css:

.leaflet-draw-tooltip {
    display: none;
}

If you would prefer Leaflet.draw support an option like you describe you are more than welcome to fork the repository and submit a pull request. If more people would find an tooltip option useful I encourage them to let me know in a positive, constructive manner.

@Zverik
Copy link
Contributor Author

Zverik commented Oct 1, 2013

Sorry if I seemed rude, English is not my primary language. I just pointed out that there are features that are not required for everyone, but enabled by default just because someone requested them. That is contrary to Leaflet principles.

I've just submitted two pull requests: one disables all tooltips (though uses a small hack with adding to L.Map options), another fixes an incostistency across handlers in disabling/enabling measurements in tooltips.

@agate
Copy link

agate commented Dec 25, 2014

+1 @Zverik Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants