Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet 0.8-dev #338

Closed
GilJ opened this issue Mar 31, 2014 · 9 comments
Closed

Leaflet 0.8-dev #338

GilJ opened this issue Mar 31, 2014 · 9 comments

Comments

@GilJ
Copy link

GilJ commented Mar 31, 2014

The leaflet master branch is currently at version 0.8-dev. I was wondering if there's any plans for supporting this master branch?

I'm getting the following error currently:

> L.version
"0.8-dev"
> var markers = new L.markerClusterGroup()
TypeError: Cannot read property 'trim' of undefined

The used leaflet 0.8-dev version is from commit 3ded683.
I tried both with the master branch, and leaflet-master branch from Leaflet.markercluster

Thanks in advance

@danzel
Copy link
Member

danzel commented Apr 1, 2014

Check out the leaflet-master branch:
https://github.com/Leaflet/Leaflet.markercluster/tree/leaflet-master

@danzel danzel closed this as completed Apr 1, 2014
@GilJ
Copy link
Author

GilJ commented Apr 1, 2014

I did and had the same problem.

@danzel
Copy link
Member

danzel commented Apr 1, 2014

You will need to run the build script to build an updated version on that branch, it doesn't have a built version checked in.
Run jake to build.

@meliborn
Copy link

Same error, even after jake

@zzhouag
Copy link

zzhouag commented Apr 29, 2015

I also got this error, I am using master version of leaflet 0.8-dev and leaflet-master version of cluster.

@Eschon
Copy link

Eschon commented Apr 29, 2015

I use markercluster with leaflet 0.8-dev and it works fine.

Are you sure you used the leaflet-master branch?
Did jake complete successful or did it throw errors?
Are you sure you copied the built files into your project after running jake?

@zzhouag
Copy link

zzhouag commented Apr 30, 2015

I only build leaflet 0.8-dev myself, and I use 'leaflet.markercluster.js' directly from the download package.
I succeed build leaflet-src.js and leaflet.js in dist folder and I'm sure copy these two files to my project...
Need I also build leaflet-master version of markercluster by myself? But there are already build files inside the dist folder of download package.

@Eschon
Copy link

Eschon commented Apr 30, 2015

Those files do not work you have to build markercluster too.

@zzhouag
Copy link

zzhouag commented May 20, 2015

Hi, I build leaflet-master version of markercluster myself and it skip this error, but when I drag the marker, new error appear as the attachment pictures
screen shot 2015-05-20 at 4 16 06 pm
screen shot 2015-05-20 at 4 15 57 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants