Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made a minor change to _zoomOrSpiderfy to Spiderfy without zooming #415

Merged
merged 5 commits into from Nov 2, 2014

Conversation

rdenniston
Copy link
Contributor

If everything in the cluster is at the same lat long. This prevents zooming into max level if there is no real reason to do so, since all points will be at the same location. This minor change increased usability in a personal project.

Thought you guys might appreciate it. This is my first pull request ever, so if I am doing this totally wrong, please let me know.

… everything in the cluster is at the same lat long. This prevents zooming into max level if there is no real reason to do so, since all points will be at the same location. This minor change increased usability in a personal project.
@danzel
Copy link
Member

danzel commented Nov 1, 2014

Travis picked up a couple of white space errors, fix those up and we'll bring this in :)

@danzel danzel closed this Nov 1, 2014
@danzel danzel reopened this Nov 1, 2014
@rdenniston
Copy link
Contributor Author

Thanks, I fixed them, i only changed it on the main source file, not anywhere else, no need to change anywhere else correct?

@danzel
Copy link
Member

danzel commented Nov 1, 2014

Yep that's the only file you should change.
Could you make a note about this feature in the readme under the defaults section (I think that is where it should go...) that should do it!

@rdenniston
Copy link
Contributor Author

Okay made the change as a note to the new behavior in the option. :)

danzel added a commit that referenced this pull request Nov 2, 2014
made a minor change to _zoomOrSpiderfy to Spiderfy without zooming
@danzel danzel merged commit 37cdfca into Leaflet:master Nov 2, 2014
@danzel
Copy link
Member

danzel commented Nov 2, 2014

Cool thanks!

@mapsam
Copy link

mapsam commented Mar 26, 2015

This is really helpful @rdenniston! Thanks for putting it together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants