wiredep

[cyrilchaponeverysens]

This commit duplicated main section of bower.json, and wiredep still doesn't work. In addition, the added "main" section is bad because it only contains the .js file, while the older one contains also .css (that wiredep can understand too)

Overall, the thing that disallows wiredep to work was not the absence of main, but rather the fact that bower doesn't seem to checkout the file bower.json itself, probably due to a bad ignore section (that I don't understand) inside bower.json. Wiredep, indeed, parses modules' bower.json to fetch main property, but when I bower install leaflet.markercluster --save, it doesn't checkout the file bower.json itself.

Temporary solution, add this section in the root of your bower.json (your main module that need leaflet.markercluster) :

  "overrides": {
    "leaflet-markercluster": {
      "main": [
        "dist/leaflet.markercluster-src.js",
        "dist/MarkerCluster.css",
        "dist/MarkerCluster.Default.css"
      ]
    }
  }

[danzel]

Send a PR to fix?

[cyrilchaponeverysens]

I have investigated a bit, and have no clue about what is making bower.json not checking out. Both ignore pattern inside bower.json itself and .gitignore seem valid.

However, the other repo Leaflet.label just acts the same way.

oO

[cyrilchaponeverysens]

How just got it.

The released tag doesn't include the bower.json file. Bower is checking out the last semver tag.

EDIT: I can submit a PR to fix main section inside bower.json, but the main issue is that bower doesn't seem to understand exotic (but still semver compliant, I agree), *v0.4.0-hotfix.1* pattern, and is checking out ~0.4.0 by default.

[cyrilchaponeverysens]

Needa get a proof this is fixed by the build process

[danzel]

Assuming this is good now