Remove "leaflet-cluster-anim" class on map remove while spiderfied #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid leaving class "leaflet-cluster-anim" on mapPane when the MCG is removed from map while it is spiderfied (see Leaflet#605)
class "leaflet-cluster-anim" checks for add then remove when spiderfying / unspiderfying, and not left behing when removing MCG from map while it is spiderfied.
_noanimationUnspiderfy was not de-bound from map "zoomend" event when group is removed from map.
danzel
added a commit
that referenced
this pull request
Dec 7, 2015
…erfied Remove "leaflet-cluster-anim" class on map remove while spiderfied
|
Awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #605, replaced
this._unspiderfy()bythis._noanimationUnspiderfy()inL.MarkerClusterGroup._spiderfierOnRemoveof file MarkerCluster.Spiderfier.js to avoid leaving behind class "leaflet-cluster-anim" on mapPane.Also added corresponding test in "spiderfySpec" spec suite.
Also took the opportunity to remove event listener
map.on('zoomend', this._noanimationUnspiderfy, this)on remove from map.