Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map.zoomPanTo() #1413

Closed
tmcw opened this issue Feb 18, 2013 · 11 comments
Closed

map.zoomPanTo() #1413

tmcw opened this issue Feb 18, 2013 · 11 comments
Assignees
Milestone

Comments

@tmcw
Copy link
Contributor

tmcw commented Feb 18, 2013

Basically it would be nice to have easey, Leaflet edition. Earlier I tried this and found it difficult to express without the abstraction level of MM.Coordinate.

@mourner
Copy link
Member

mourner commented Feb 18, 2013

I'll try to get my hands on this during the week. Shouldn't be too hard to do in theory.

@ghost ghost assigned mourner Feb 18, 2013
@uberbuilder
Copy link

This looks to me like something that would solve my issue: 1363

@tmcw
Copy link
Contributor Author

tmcw commented Feb 27, 2013

@mourner are you currently working on this? I can work on a patch.

@mourner
Copy link
Member

mourner commented Feb 27, 2013

I've looked into this a bit (see the recent zoom anim refactoring to make things clearer) but still not sure if it can be implemented easily (without tweaking some parts) — it seems that there may be issues with loading new tiles during the animation on intermediary zoom levels. You can take a stab at this though, or at least review the current zoom animation code and see if there are any bottlenecks or suggestions for improvement.

@uberbuilder
Copy link

@mourner YAY!!!! I'm so happy to hear you're working on this - I really need this for my application. I was going to spend some time on this after I finished working on some documentation translation on a different project I'm contributing to.

I never really thought about the whole loading new tiles after the zoom. for my application. For my needs I'm only panning a few pixels across. Link to code: currently 200px Link to live demo: here is the project in action. So, the panning happens so fast that it's okay to have the new tiles load after the entire animation. I can see what you were thinking though, and that's a great idea. Perhaps we could add a passable flag on the function? Something which would obviously be named better than loadNewTilesDuringPanAnimation = true/false. Maybe this would allow you to create a more simple version now and add the tile-feature later on after you figure it out?

I'll pose the question - does anyone want to zoom, load new tiles and then pan? For me, I'm perfectly okay with tiles loading after the whole animation is complete.

The best version is obviously having them load during the pan (maybe with a flag to turn that off if it's a performance hog/buggy for mobile)

@dribnet
Copy link

dribnet commented Mar 6, 2013

+1

@mourner
Copy link
Member

mourner commented Dec 12, 2013

Going to tackle this feature during before the end of the next week.

@danzel
Copy link
Member

danzel commented Dec 12, 2013

during before? You've been working too hard mourner!

@mourner
Copy link
Member

mourner commented Dec 12, 2013

Lol

@mourner
Copy link
Member

mourner commented Jan 15, 2014

A work in progress in #2382, will be done very soon.

@mourner
Copy link
Member

mourner commented Oct 29, 2014

Done.

@mourner mourner closed this as completed Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants