Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice to have feature - Toggle the display of a marker's popup on click #1761

Merged
merged 1 commit into from Jun 19, 2013

Conversation

paulRbr
Copy link
Contributor

@paulRbr paulRbr commented Jun 16, 2013

Hi guys,

Thanks for the job your doing! I was searching for an open source framework to build interactive maps and here it is Leaflet! 馃憤

I'm pretty new with it but I quickly came up to a simple - yet disturbing - behaviour.

Indeed when interacting with maps in my browser I most commonly close marker's popups by simply clicking on the marker itself. I thought that it would be a nice to have minor feature so I implemented and specified it in this 1af9769 commit.

Hope I can add some contribution to this cool project =)

Have a nice week!
Paul

@mourner
Copy link
Member

mourner commented Jun 19, 2013

Looks good! :) I was going to implement this eventually but didn't get my hands on it yet, so thanks for the pull!

mourner added a commit that referenced this pull request Jun 19, 2013
Nice to have feature - Toggle the display of a marker's popup on click
@mourner mourner merged commit 287f085 into Leaflet:master Jun 19, 2013
@paulRbr paulRbr deleted the marker-togglePopup branch June 19, 2013 14:41
@paulRbr paulRbr restored the marker-togglePopup branch June 19, 2013 14:57
@paulRbr paulRbr deleted the marker-togglePopup branch June 19, 2013 14:57
@newmanw
Copy link
Contributor

newmanw commented Jul 26, 2013

Wondering if this fix the the root cause of this bug:
#1907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants