Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaflet 1.0.0-b1 noWrap not present anymore #3691

Closed
vas85 opened this issue Jul 30, 2015 · 3 comments
Closed

leaflet 1.0.0-b1 noWrap not present anymore #3691

vas85 opened this issue Jul 30, 2015 · 3 comments
Assignees
Milestone

Comments

@vas85
Copy link

vas85 commented Jul 30, 2015

Hi.

Thanks for the great library.

I noticed in master noWrap functionality documented here is not there anymore.

It was removed in commit 5e6f95d and commented out in commit cdfaad9.

Going forward is noWrap going to be deprecated in 1.x? Or will it come back?

Thanks!

Vas

@mourner
Copy link
Member

mourner commented Jul 30, 2015

No, probably missed out. Although not as critical since wrapping is now dictated by CRS by default, so e.g. earth CRS have longitude wrapping, but CRS.Simple doesn't.

@vas85
Copy link
Author

vas85 commented Jul 31, 2015

Makes sense.

In my application I need earth CRS (because I have some tile data created via gdal2tiles tool that I cannot change right now).

The hack I put in my code to remove wrapping is just this:
delete L.CRS.Earth.wrapLng;

Happy to submit a pull request to add a param to control wrapping if you think its a good idea.

@rancas
Copy link

rancas commented Sep 10, 2015

Hi, I am trying to create a CRS.Simple layer with no wrapping but with no luck. It worked with version 0.7.5 using the following code:

var map = L.map('map').setView([0, 0], 0,crs= 'L.CRS.Simple');
var background = new L.FeatureGroup();
map.addLayer(background);
var tiles = L.tileLayer(scope.diagram.tiles_site+scope.diagram.tile_dir+'{z}/{x}/{y}.png', {
          width: 2048,
          height: 2048,
          minZoom: 0,
          maxZoom: 4,
          continuousWorld: false,
          noWrap: false,
          tms: true,
 });
background.addLayer(tiles);

We generate our tiles and it is not a "real map":
How should I have the same result if I cannot use noWrap attribute?
Thanks.
Luca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants