Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG-Path without attributes #3789

Closed
fab1an opened this issue Aug 30, 2015 · 5 comments
Closed

SVG-Path without attributes #3789

fab1an opened this issue Aug 30, 2015 · 5 comments
Labels

Comments

@fab1an
Copy link
Contributor

fab1an commented Aug 30, 2015

For performance reasons I would like to set only the classNames of the SVG-paths and skip all the "stroke-width" attributes etc.

Is that possible?

@IvanSanchez
Copy link
Member

Is that possible?

Yes.

Have you done any benchmark of the performance gains of doing so?

@fab1an
Copy link
Contributor Author

fab1an commented Aug 30, 2015

Yes, but a year ago in an application which displays about 4000 svg-polygons. I have patched this behaviour in a version for myself and I would like to go back to upstream-leaflet.

@IvanSanchez
Copy link
Member

I would like to go back to upstream-leaflet.

That's what pull requests are for :-)

@IvanSanchez
Copy link
Member

Let's make a reference to #2662.

Having thought a bit about the issue, it should be easy to just set stroke and fill to false, then let the className do its magic. Even do a small plugin for the SVG renderer which forces that. But doing so in a way compatible with Canvas can be insanely difficult.

@fab1an
Copy link
Contributor Author

fab1an commented Jul 17, 2016

I'm closing this, I don't really need it anymore, found my performance-gains somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants