Fix(Map): call stopLocate on map.remove #5893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that Geolocation handlers (namely _handleGeolocationResponse and _handleGeolocationError) do not try to access DOM elements which have been cleared by map.remove(). Of course developer should currently call map.stopLocate() manually before map.remove(), but it looks like he/she may forget it. Check for _locationWatchId is not perfect (watch may have been already stopped), but calling stopLocate again does not harm. It prevents trying to access the Geolocation API if locate had never been called, even though doing so should not harm either.
mourner
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Following SO post Leaflet .locate watch option breaks .locate after changing tab, this PR proposes to automatically call
map.stopLocate()as part ofmap.remove()process, so that app developer does not need to remember about having used the Geolocation withwatchoption or not.Otherwise, Geolocation handlers (namely
_handleGeolocationResponseand_handleGeolocationError) are still called regulary and try to access DOM elements which have been previously cleared bymap.remove().Check for
_locationWatchIdis not perfect (watch may have been already stopped), but callingstopLocateagain does not harm. It prevents trying to access the Geolocation API iflocatehad never been called, even though doing so should not harm either.