Fix(SVGrenderer): reset svgSize on remove from map #5966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that when the SVG Renderer is re-used and re-added on map, in `_update` method, the check on `_svgSize` triggers and re-assigns `width` and `height` attributes on the `_container`. Otherwise, the latter no longer has width and height, therefore is invisible, until the viewport size is changed.
|
Nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR resets the
_svgSizecache on SVG Renderer, so that when it is re-used and re-added on map, in_updatemethod, the check on_svgSizetriggers and re-assignswidthandheightattributes on the_container.Otherwise, the latter no longer has width and height, therefore is invisible, until the viewport size is changed.
I will try to include a unit test later on.
Fix #5960