Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Monks Enhanced Journals Module so that it can find the image #42

Closed
Drazev opened this issue May 5, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Drazev
Copy link

Drazev commented May 5, 2024

Monks-enhanced journals is a popular tool that places journal images in a different location.

I would like to make a minor adjustment that will enable it to find the image when quests use a reference to the monk's enhanced journal. Presently when the enriched attempts to find the image on a monks enhanced journal page it will be undefined and show as blank.

@Drazev Drazev added the enhancement New feature or request label May 5, 2024
@Drazev
Copy link
Author

Drazev commented May 5, 2024

I have modified the enhancer slightly so that when it finds a journal page it will first attempt to check the monks enhanced journal location and if that returns undefined it will search the normal location.

@typhonrt
Copy link
Collaborator

typhonrt commented May 6, 2024

In the past MEJ custom journal types were supported prior to any changes in MEJ to store image paths in a custom flag. I only test FQL every core release of Foundry, so not sure when that MEJ change occurred. I'll accept this PR, but modify it accordingly when I work on the v12 FQL release.

@Drazev
Copy link
Author

Drazev commented May 6, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants