Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASG on_demand_price_multiplier preference #483

Open
sdaniel-r7 opened this issue Mar 22, 2022 · 2 comments
Open

ASG on_demand_price_multiplier preference #483

sdaniel-r7 opened this issue Mar 22, 2022 · 2 comments

Comments

@sdaniel-r7
Copy link

Github issue

Issue type

  • Bug Report

Build number

build 1.0-custom-f295a1f
Commit SHA1: f295a1f

Configuration

Environment

  • AWS region: us-east-1
  • Type of environment: VPC

Summary

Appears as if the ASG multiplier value is fetched but not utilized. Instead it continues to rely on the lambda multiplier value for price calc.

Steps to reproduce


Create lambda env vars ON_DEMAND_PRICE_MULTIPLIER (0.67) and ASG tags (0.55) for autospotting_on_demand_price_multiplier and launch 2 or more instances

Expected results

When provided, the Auto Scaling Group multiplier should be used

Actual results

When lambda has: ON_DEMAND_PRICE_MULTIPLIER and the Auto Scaling Group also has a multiplier: autospotting_on_demand_price_multiplier, the autospotting code does not use the auto scaling group- instead it relies on the lambda multiplier.

@cristim
Copy link
Member

cristim commented Mar 29, 2022

Thanks for reporting this issue.

I currently only work on issues and feature requests submitted by paying customers.

If you installed AutoSpotting from the marketplace tell me your account number on Slack and I'll look into this.

Otherwise I'm going to leave this open just in case someone else is willing to give it a try and contribute a pull request, which I'm more than happy to consider.

@cristim
Copy link
Member

cristim commented Mar 6, 2023

@sdaniel-r7 is this still of interest to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants