Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect enums in variableDefinitions #59

Merged
merged 10 commits into from Mar 22, 2021
Merged

Conversation

brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Mar 22, 2021

This is an old work account. Please reference @brandonchinn178 for all future communication


Fixes #58

@brandon-leapyear brandon-leapyear changed the title Generate enums that only appear in parameters Collect enums in variableDefinitions Mar 22, 2021
size: 534126
url: https://raw.githubusercontent.com/commercialhaskell/stackage-snapshots/master/lts/16/31.yaml
sha256: 637fb77049b25560622a224845b7acfe81a09fdb6a96a3c75997a10b651667f6
original: lts-16.31
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to commit this in #56

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #59 (6164459) into master (d2d3bed) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   91.81%   91.89%   +0.08%     
==========================================
  Files          29       29              
  Lines         464      481      +17     
  Branches       58       62       +4     
==========================================
+ Hits          426      442      +16     
- Misses         38       39       +1     
Impacted Files Coverage Δ
graphql-codegen-haskell/src/parse/operation.ts 100.00% <100.00%> (ø)
...ql-codegen-haskell/src/parse/variableDefinition.ts 100.00% <100.00%> (ø)
example/src/Example/GraphQL/Scalars/Date.hs 45.45% <0.00%> (-9.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d3bed...6164459. Read the comment docs.

@brandon-leapyear brandon-leapyear merged commit f0e0618 into master Mar 22, 2021
@brandon-leapyear brandon-leapyear deleted the chinn/param-enums branch March 22, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate enums that appear only in parameters
1 participant