New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event for transport error #158
Comments
Nope a throw is correct, this should never happen. The packet shouldn't reach the |
But it threw for me :) What should I do to catch it earlier or deal with this? |
We should fix the underlying problem; that we pass a packet to a transport when it can't write it. |
@cadorn, could you share some explicit code that triggers the throw? |
No. Sorry. I cannot remember what the conditions where. It happened while using it within Cloud9 IDE. |
@guille can I recommend closing this for now, and reopening if it pops up again? |
What @J-Salazar suggested: closing for now. Please reopen if this reappears. |
Create an event for this transport error instead of throwing it:
https://github.com/LearnBoost/engine.io-client/blob/a86505ee9f04566ead133b9f88478f4b36cf5d52/lib/transport.js#L97
It could still throw by default if there are no listeners registered.
The text was updated successfully, but these errors were encountered: