Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event for transport error #158

Closed
cadorn opened this issue May 9, 2013 · 7 comments
Closed

Event for transport error #158

cadorn opened this issue May 9, 2013 · 7 comments

Comments

@cadorn
Copy link
Contributor

cadorn commented May 9, 2013

Create an event for this transport error instead of throwing it:

https://github.com/LearnBoost/engine.io-client/blob/a86505ee9f04566ead133b9f88478f4b36cf5d52/lib/transport.js#L97

It could still throw by default if there are no listeners registered.

@rauchg
Copy link
Contributor

rauchg commented May 9, 2013

Nope a throw is correct, this should never happen. The packet shouldn't reach the Transport.

@cadorn
Copy link
Contributor Author

cadorn commented May 10, 2013

But it threw for me :)

What should I do to catch it earlier or deal with this?

@rauchg
Copy link
Contributor

rauchg commented May 10, 2013

We should fix the underlying problem; that we pass a packet to a transport when it can't write it.

@rauchg rauchg mentioned this issue May 26, 2013
@JulianSlzr
Copy link

@cadorn, could you share some explicit code that triggers the throw?

@cadorn
Copy link
Contributor Author

cadorn commented Feb 10, 2014

No. Sorry. I cannot remember what the conditions where. It happened while using it within Cloud9 IDE.

@JulianSlzr
Copy link

@guille can I recommend closing this for now, and reopening if it pops up again?

@rase-
Copy link
Contributor

rase- commented Aug 1, 2014

What @J-Salazar suggested: closing for now. Please reopen if this reappears.

@rase- rase- closed this as completed Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants