Removed an old test that checked the ws api works (which is now remov…

…ed) and fixed a global leak in JSONP tests
socketio · Apr 11, 2014 · 83caa81 · 83caa81
1 parent 32db7c4
commit 83caa81
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 24 deletions.
diff --git a/test/jsonp.js b/test/jsonp.js
@@ -77,8 +77,8 @@ describe('JSONP', function () {
 
   after(function () {
     delete document.getElementsByTagName
-      , document.createElement
-      , document;
+      , document.createElement;
+    delete global.document;
   });
 
   describe('handshake', function () {
@@ -114,7 +114,7 @@ describe('JSONP', function () {
           });
         });
       });
-    }); 
+    });
 
     it('should arrive from server to client and back with binary data (pollingJSONP)', function(done) {
       var binaryData = new Buffer(5);
@@ -137,7 +137,7 @@ describe('JSONP', function () {
       });
     });
   });
-  
+
   describe('close', function () {
     it('should trigger when server closes a client', function (done) {
       var engine = listen( { allowUpgrades: false, transports: ['polling'] }, function (port) {

diff --git a/test/server.js b/test/server.js
@@ -895,26 +895,6 @@ describe('server', function () {
       });
     });
 
-    it('should arrive from server to client with ws api', function (done) {
-      var opts = { allowUpgrades: false, transports: ['websocket'] };
-      var engine = listen(opts, function (port) {
-        var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });
-        engine.on('connection', function (conn) {
-          conn.send('a');
-          conn.close();
-        });
-        socket.onopen = function () {
-          socket.onmessage = function (msg) {
-            expect(msg.data).to.be('a');
-            expect('' + msg == 'a').to.be(true);
-          };
-          socket.onclose = function () {
-            done();
-          };
-        };
-      });
-    });
-
     it('should arrive from server to client (ws)', function (done) {
       var opts = { allowUpgrades: false, transports: ['websocket'] };
       var engine = listen(opts, function (port) {