Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model.remove() should allow passing options #2724

Closed
vkarpov15 opened this issue Feb 28, 2015 · 3 comments
Closed

Model.remove() should allow passing options #2724

vkarpov15 opened this issue Feb 28, 2015 · 3 comments
Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Milestone
5.7.4

Comments

@vkarpov15
Copy link
Collaborator

No description provided.

@vkarpov15 vkarpov15 added the enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature label Feb 28, 2015
@vkarpov15 vkarpov15 modified the milestones: 4.1, 5.0 Feb 28, 2015
@hasezoey
Copy link
Collaborator

hasezoey commented Aug 11, 2022 •
edited

From what i can tell, the remove function accepts options, since ~5.7.4 402db1a - or is that just for session and other options are required?

https://github.com/Automattic/mongoose/blob/master/lib/model.js#L963-L976

so i think this can be closed
cc @vkarpov15 @Uzlopak @AbdelrahmanHafez

@AbdelrahmanHafez
Copy link
Collaborator

Thanks @hasezoey

@hasezoey
Copy link
Collaborator

@AbdelrahmanHafez this should maybe also be added to the proper milestone

@hasezoey hasezoey mentioned this issue Aug 11, 2022
Merged
@AbdelrahmanHafez AbdelrahmanHafez modified the milestones: Parking Lot, 5.7.4 Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This issue is a user-facing general improvement that doesn't fix a bug or add a new feature
Projects
None yet
Milestone
5.7.4
Development

No branches or pull requests
3 participants
@vkarpov15 @hasezoey @AbdelrahmanHafez