Populate can bail out too early if empty array in the field being populated #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate could bail out too early if the first document retrieved from the parent model contained an empty array in the field used for populating the child model.
|
I have an alternate fix for this bug in #1053 |
aheckmann
added a commit
that referenced
this pull request
Aug 17, 2012
|
merged, thanks! |
aheckmann
added a commit
that referenced
this pull request
Aug 23, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate could bail out too early if the first document retrieved from the parent model contained an empty array in the field used for populating the child model. The _populate method will invoke the next function immediately in this event rather than being delayed by a database read causing the loop to end immediately. In order to fix this, I wrapped the call to _populate in "process.nextTick()".