connect_failed doesn't fire

[giggsey]

path = 'myurl.giggsey.com:port';

this.socket = io.connect(path, {
            'force new connection': true,
            'max reconnection attempts': 5,
            'connect timeout': 5000
        });

this.socket.on('connect_failed', function() {
            console.log('connect-failed');
        });

However, the connect_failed doesn't seem to appear.

I've tried with the latest released socket.io-client (0.8.7) also with the latest released socket.io (0.8.6).

I've seen an approved pull request which was related to this, and I'm pretty sure it's in the version I have.

[Ricket]

I am also not receiving a connect_failed event, calling io.connect with a nonsense path and the same options. Using the latest socket.io from NPM (version 0.9.0) with Chrome 17 in OSX.

Edit: just upgraded to version 0.9.1-1 via NPM, and added logging to ensure that this version is being used (which it is) - same result, no connect_failed event fired.

Edit2:

After digging around the source for a while, I happened upon the "error" event. It seems that in most cases when a connection fails, the error event is triggered instead of connect_failed. Looks like connect_failed is reserved for specific cases such as when the connection succeeds but the handshake fails, when an error packet is received with reason=='unauthorized', and perhaps others.

So the "solution" to this is to subscribe to the "error" event (as well as 'connect_failed'). In my app, I translate the error event into 'Error connecting to server', while connect_failed shows 'Connection failed; try refreshing the page'. I'm not yet sure if this is correct or even adequate, but until I get a chance to test these situations, I think it'll do.

[coredump]

I can confirm that getting a handler for the 'error' event solves at least part of this problem.